Skip to content

test(i18n): add RTL-safe font cascade regression coverage#1997

Open
kumararyan1 wants to merge 4 commits intokoala73:mainfrom
kumararyan1:dev/issue-1445-font-rtl
Open

test(i18n): add RTL-safe font cascade regression coverage#1997
kumararyan1 wants to merge 4 commits intokoala73:mainfrom
kumararyan1:dev/issue-1445-font-rtl

Conversation

@kumararyan1
Copy link
Copy Markdown

@kumararyan1 kumararyan1 commented Mar 21, 2026

Summary

Adds a regression test for the font preference logic so RTL and CJK font stacks continue composing through --font-body-base instead of being broken by an inline --font-body override.

Type of change

  • Bug fix
  • New feature
  • New data source / feed
  • New map layer
  • Refactor / code cleanup
  • Documentation
  • CI / Build / Infrastructure

Affected areas

  • Map / Globe
  • News panels / RSS feeds
  • AI Insights / World Brief
  • Market Radar / Crypto
  • Desktop app (Tauri)
  • API endpoints (/api/*)
  • Config / Settings
  • Other:

Checklist

  • Tested on worldmonitor.app variant
  • Tested on tech.worldmonitor.app variant (if applicable)
  • New RSS feed domains added to api/rss-proxy.js allowlist (if adding feeds)
  • No API keys or secrets committed
  • TypeScript compiles without errors (npm run typecheck)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 21, 2026

@kumararyan1 is attempting to deploy a commit to the Elie Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the trust:caution Brin: contributor trust score caution label Mar 21, 2026
@koala73 koala73 added High Value Meaningful contribution to the project Ready to Merge PR is mergeable, passes checks, and adds value labels Mar 26, 2026
@SebastienMelki
Copy link
Copy Markdown
Collaborator

@kumararyan1 — thanks for the contribution! A couple of things before this can move forward:

  1. Branch has merge conflicts — please rebase on main
  2. The PR description says bug fix, but the file changes show 2 additions with no deletions. Could you clarify what the actual source-level fix is?
  3. The PR title has a leading space — minor but worth cleaning up

@SebastienMelki
Copy link
Copy Markdown
Collaborator

Note: merge conflicts with main. Fork PR — can't rebase from maintainer side. @kumararyan1 — please rebase on current main when addressing the review comments.

@kumararyan1 kumararyan1 force-pushed the dev/issue-1445-font-rtl branch from f0eb4b3 to 89741aa Compare March 30, 2026 20:45
@kumararyan1 kumararyan1 changed the title fix(i18n): lock in RTL-safe font preference cascade test(i18n): add RTL-safe font cascade regression coverage Mar 30, 2026
@kumararyan1
Copy link
Copy Markdown
Author

kumararyan1 commented Mar 30, 2026

@SebastienMelki Thanks for taking a look at this PR and for the feedback.
Was looking for some first issues to work on, and this one came across my plate, so I appreciate you pointing this out.

  • I’ve now rebased onto current main and resolved the merge conflict.

After rebasing, I checked and confirmed the actual fix for #1445 was already merged in #2318. This PR is no longer trying to fix the bug itself. It only adds regression coverage to make sure the data-font="system" approach and the RTL/CJK cascade do not get broken again. If that’s not useful on its own, I’m happy to close it.
The test makes sure that:

  1. the system font preference is applied through data-font="system"
  2. switching back to mono removes that attribute
  3. RTL and CJK rules still compose through --font-body-base

Also, fixed the title :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Value Meaningful contribution to the project Ready to Merge PR is mergeable, passes checks, and adds value trust:caution Brin: contributor trust score caution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants